Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: skip already enslaved interfaces #450

Merged
merged 1 commit into from Dec 4, 2018
Merged

network: skip already enslaved interfaces #450

merged 1 commit into from Dec 4, 2018

Conversation

haraldh
Copy link
Collaborator

@haraldh haraldh commented Aug 21, 2018

No description provided.

if [ -n "$dev" ]; then
[ "$dev" != "$netif" ] && continue
else
iface_is_enslaved "$dev" && continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look correct. The else branch is executed only if $dev is an empty string.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh.. should be "$netif"

Copy link
Member

@lnykryn lnykryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnykryn
Copy link
Member

lnykryn commented Dec 3, 2018

@centos-ci retest this please

@haraldh haraldh merged commit f6e3b59 into master Dec 4, 2018
@haraldh haraldh deleted the enslaved branch May 29, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants